Skip to content

Conversation

ELDment
Copy link
Contributor

@ELDment ELDment commented Oct 14, 2025

Description

Complete refactoring of CommandTracked (renamed to CommandTrackedService) and registered ConsoleOutput and CommandExecuteHook as global events.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement
  • Build/CI improvement

Related Issues

Fixes #(issue number for circular dependency problem)
Related to #38 #41

Changes Made

  • Native changes (C++)
  • Managed Changes (C#)
  • API additions/modifications
  • Memory management improvements
  • Network handling changes
  • SDK updates
  • Build system changes

Detailed Changes

List the specific changes made:

Testing

Test Environment

  • OS: Windows 11
  • Game: Counter-Strike 2

Test Cases

Describe the test cases you've run:

Breaking Changes

List any breaking changes and migration steps:

  • CommandTracked class renamed to CommandTrackedService
  • Constructor signature changed to accept Lazy instead of direct ISwiftlyCore

Performance Impact

  • No performance impact
  • Positive performance impact
  • Negative performance impact (explain below)
  • Performance impact unknown

Details:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots/Videos (if applicable)

Add screenshots or videos demonstrating the changes:

Additional Notes


For Maintainers

  • Code review completed
  • Tests pass
  • Ready to merge

@ELDment ELDment marked this pull request as ready for review October 14, 2025 02:21
@ELDment ELDment changed the title refactor: Ensure all implementations of #38 and #41 perfectly follow SwiftlyS2 code standards refactor: Ensure all implementations of #38 and #41 perfectly follow SwiftlyS2 code standards Oct 14, 2025
@samyycX
Copy link
Collaborator

samyycX commented Oct 14, 2025

Thank you

@samyycX samyycX merged commit eb1aa35 into swiftly-solution:beta Oct 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants