Skip to content

Conversation

ELDment
Copy link
Contributor

@ELDment ELDment commented Oct 16, 2025

Description

Introduce configuration for plugin auto-reload system.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement
  • Build/CI improvement

Related Issues

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Changes Made

  • Native changes (C++)
  • Managed Changes (C#)
  • API additions/modifications
  • Memory management improvements
  • Network handling changes
  • SDK updates
  • Build system changes

Detailed Changes

List the specific changes made:

  • Updated core.example.jsonc with new plugin auto-reload configuration section

Testing

Test Environment

  • OS: Windows 11
  • Game: Counter-Strike 2

Test Cases

Describe the test cases you've run:

Breaking Changes

List any breaking changes and migration steps:

Performance Impact

  • No performance impact
  • Positive performance impact
  • Negative performance impact (explain below)
  • Performance impact unknown

Details:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots/Videos (if applicable)

Add screenshots or videos demonstrating the changes:

N/A

Additional Notes

Any additional information, context, or notes for reviewers:


For Maintainers

  • Code review completed
  • Tests pass
  • Ready to merge

@ELDment
Copy link
Contributor Author

ELDment commented Oct 16, 2025

// meh, Idk why, but when using Mstsc to copy and overwrite files
// it sometimes triggers: "System.IO.IOException: The process cannot access the file because it is being used by another process."
// therefore, we use a retry mechanism

image

@ELDment ELDment changed the title feat: Introduce configuration for plugin auto-reload system fix: Files overwritten via Mstsc may trigger auto-reload with IO exceptions Oct 16, 2025
Copy link
Member

@skuzzis skuzzis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ELDment ELDment requested a review from skuzzis October 17, 2025 02:16
@samyycX samyycX merged commit 473ff3c into swiftly-solution:beta Oct 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants