Announce SwiftWasm 5.5.0 and related releases #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Also, in this version of JavaScriptKit we're simplifying the `JSClosure` API. You no longer need to | ||
| release instances of this class manually, they're automatically garbage-collected by the browser | ||
| after your Swift code no longer has any references to them. This is achieved with the new | ||
| `FinalizationRegistry` Web API, for which we had to significantly increase minimum browser versions |
Member
There was a problem hiding this comment.
Could you note that there is still a cyclic reference issue. e.g.
var button = document.createElement("button")
button.onclick = .object(JSClosure { [button] in
// this capture makes a reference cycle
print(button)
})
┌─> JSObject (button in Swift) -> HTMLElement (button in JS) ────┐
└── JSClosure (onclick in Swift) <─> Closure (onclick in JS) <───┘
In this case, when button element will be disappeared from the main DOM tree, it cannot be deallocated, and the onlick closure will be still referenced. So programmers have to cut the cycle by themselves using weak reference.
So we need to mention that FinalizationRegistry doesn't solve the all GC problem but it only solves dangling closure issue.
Co-authored-by: Jed Fox <git@jedfox.com>
kateinoigakukun
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.