What's New in SwiftWasm #3 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
approved these changes
Oct 30, 2020
yonihemi
reviewed
Oct 30, 2020
Co-authored-by: Yuta Saito <kateinoigakukun@gmail.com>
Co-authored-by: Yuta Saito <kateinoigakukun@gmail.com>
Co-authored-by: yonihemi <jonathan@hemi.dev>
kateinoigakukun
approved these changes
Oct 30, 2020
yonihemi
approved these changes
Oct 30, 2020
| support. This mirrors our existing [C++ implementation in the legacy | ||
| driver](https://github.com/swiftwasm/swift/blob/swiftwasm/lib/Driver/WebAssemblyToolChains.cpp), and | ||
| it's great that the new parts of the Swift compiler rewritten in Swift are going to support | ||
| WebAssembly too. While Swift Driver in that enabled in any toolchain by default, we're definitely |
Member
There was a problem hiding this comment.
I'm not quite sure what the beginning of this sentence is saying. Maybe:
Suggested change
| WebAssembly too. While Swift Driver in that enabled in any toolchain by default, we're definitely | |
| WebAssembly too. While Swift Driver isn't enabled in any toolchain by default, we're definitely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I didn't miss anything, suggestions and feedback are welcome as usual.
I've also added new fonts to the theme so that it feels less bland.
Before:
After: