Skip to content

Fix click through issue and rebuild dist #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

Fix click through issue and rebuild dist #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12d6642
Update dist/jquery.contextMenu.js
KevinAHM May 4, 2025
6961681
fix: also update source and rebuild dist
bbrala Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/jquery.contextMenu.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
* Authors: Björn Brala (SWIS.nl), Rodney Rehm, Addy Osmani (patches for FF)
* Web: http://swisnl.github.io/jQuery-contextMenu/
*
* Copyright (c) 2011-2020 SWIS BV and contributors
* Copyright (c) 2011-2025 SWIS BV and contributors
*
* Licensed under
* MIT License http://www.opensource.org/licenses/mit-license
*
* Date: 2020-05-13T13:55:37.023Z
* Date: 2025-11-04T11:10:12.861Z
*/
@-webkit-keyframes cm-spin {
0% {
Expand Down
97 changes: 92 additions & 5 deletions dist/jquery.contextMenu.js
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
* Authors: Björn Brala (SWIS.nl), Rodney Rehm, Addy Osmani (patches for FF)
* Web: http://swisnl.github.io/jQuery-contextMenu/
*
* Copyright (c) 2011-2020 SWIS BV and contributors
* Copyright (c) 2011-2025 SWIS BV and contributors
*
* Licensed under
* MIT License http://www.opensource.org/licenses/mit-license
*
* Date: 2020-05-13T13:55:36.983Z
* Date: 2025-11-04T11:10:13.179Z
*/

// jscs:disable
Expand All @@ -31,6 +31,36 @@

'use strict';

// helper function to check for rapid interactions after menu display
var isInteractionTooFast = function($element) {
if (!('ontouchstart' in window
|| navigator.maxTouchPoints > 0 || navigator.msMaxTouchPoints > 0)) {
return false;
}
var interactionTime = Date.now();
var $liItem = $element.is('input, textarea, select') ? $element.closest('.context-menu-item') : $element;
if (!$liItem || !$liItem.length) {
return false;
}
var $parentMenu = $liItem.parent();
if (!$parentMenu || !$parentMenu.length) {
return false;
}

// only apply the check for items within submenus
if ($parentMenu.hasClass('context-menu-root')) {
return false;
}

var showTimestamp = $parentMenu.data('_showTimestamp');
var timeDifference = showTimestamp ? interactionTime - showTimestamp : Infinity;

// threshold for fast interaction (e.g., mobile tap)
var threshold = 50; // ms

return timeDifference < threshold;
};

// TODO: -
// ARIA stuff: menuitem, menuitemcheckbox und menuitemradio
// create <menu> structure if $.support[htmlCommand || htmlMenuitem] and !opt.disableNative
Expand Down Expand Up @@ -824,6 +854,11 @@
opt = data.contextMenu,
root = data.contextMenuRoot;

// prevent fast hover on mobile tap-through
if (isInteractionTooFast($this)) {
return;
}

root.hovering = true;

// abort if we're re-entering
Expand Down Expand Up @@ -877,11 +912,27 @@
key = data.contextMenuKey,
callback;

// prevent fast click-through on mobile taps
if (isInteractionTooFast($this)) {
e.preventDefault();
e.stopImmediatePropagation();
return;
}

// abort if the key is unknown or disabled or is a menu
if (!opt.items[key] || $this.is('.' + root.classNames.disabled + ', .context-menu-separator, .' + root.classNames.notSelectable) || ($this.is('.context-menu-submenu') && root.selectableSubMenu === false )) {
// explicitly handle non-selectable submenu clicks first to stop propagation
if ($this.is('.context-menu-submenu') && root.selectableSubMenu === false) {
e.preventDefault();
e.stopImmediatePropagation(); // Stop event here for non-selectable submenus
return;
}

// original check for other non-clickable/disabled items
if (!opt.items[key] || $this.is('.' + root.classNames.disabled + ', .context-menu-separator, .' + root.classNames.notSelectable)) {
return;
}

// if it wasn't a non-selectable submenu or other disabled item, prevent default and stop propagation before callback
e.preventDefault();
e.stopImmediatePropagation();

Expand Down Expand Up @@ -943,6 +994,10 @@
// position sub-menu - do after show so dumb $.ui.position can keep up
if (opt.$node) {
root.positionSubmenu.call(opt.$node, opt.$menu);
if (opt.$menu) {
var focusShowTimestamp = Date.now();
opt.$menu.data('_showTimestamp', focusShowTimestamp);
}
}
},
// blur <command>
Expand Down Expand Up @@ -1008,6 +1063,9 @@
opt.$menu.css(css)[opt.animation.show](opt.animation.duration, function () {
$trigger.trigger('contextmenu:visible');

var rootShowTimestamp = Date.now();
opt.$menu.data('_showTimestamp', rootShowTimestamp);

op.activated(opt);
opt.events.activated(opt);
});
Expand Down Expand Up @@ -1116,6 +1174,16 @@
root = opt;
}

// define handler for fast input clicks
var handleFastInputClick = function(e) {
var $inputClicked = $(this);
if (isInteractionTooFast($inputClicked)) {
e.preventDefault();
e.stopImmediatePropagation();
return false;
}
};

// create contextMenu
opt.$menu = $('<ul class="context-menu-list"></ul>').addClass(opt.className || '').data({
'contextMenu': opt,
Expand Down Expand Up @@ -1266,6 +1334,8 @@
.val(item.value || '')
.prop('checked', !!item.selected)
.prependTo($label);
// prevent checkbox default action on fast click-through
$input.on('click', handleFastInputClick);
break;

case 'radio':
Expand All @@ -1274,6 +1344,8 @@
.val(item.value || '')
.prop('checked', !!item.selected)
.prependTo($label);
// prevent radio default action on fast click-through
$input.on('click', handleFastInputClick);
break;

case 'select':
Expand Down Expand Up @@ -1579,18 +1651,32 @@
var $menu = opt.$menu;
var $menuOffset = $menu.offset();
var winHeight = $(window).height();
var winWidth = $(window).width();
var winScrollTop = $(window).scrollTop();
var winScrollLeft = $(window).scrollLeft();
var menuHeight = $menu.height();
var outerHeight = $menu.outerHeight();
var outerWidth = $menu.outerWidth();

if(menuHeight > winHeight){
$menu.css({
'height' : winHeight + 'px',
'overflow-x': 'hidden',
'overflow-y': 'auto',
'top': winScrollTop + 'px'
});
} else if(($menuOffset.top < winScrollTop) || ($menuOffset.top + menuHeight > winScrollTop + winHeight)){
} else if($menuOffset.top < winScrollTop){
$menu.css({
'top': winScrollTop + 'px'
'top': winScrollTop + 'px'
});
} else if($menuOffset.top + outerHeight > winScrollTop + winHeight){
$menu.css({
'top': $menuOffset.top - (($menuOffset.top + outerHeight) - (winScrollTop + winHeight)) + "px"
});
}
if($menuOffset.left + outerWidth > winScrollLeft + winWidth){
$menu.css({
'left': $menuOffset.left - (($menuOffset.left + outerWidth) - (winScrollLeft + winWidth)) + "px"
});
}
}
Expand Down Expand Up @@ -2131,4 +2217,5 @@
$.contextMenu.handle = handle;
$.contextMenu.op = op;
$.contextMenu.menus = menus;

});
4 changes: 2 additions & 2 deletions dist/jquery.contextMenu.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading