Skip to content

Closes #391 - Group permission cascade enabled #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Closes #391 - Group permission cascade enabled #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routers/group-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ router.get('/groupconfig/:id', auth, [
], validate, async (req, res) => {
try {
let groupconfig = await Services.getGroupConfigById(req.params.id);
groupconfig = await verifyOwnership(req.admin, groupconfig, groupconfig.domain, ActionTypes.READ, RouterTypes.GROUP);
groupconfig = await verifyOwnership(req.admin, groupconfig, groupconfig.domain, ActionTypes.READ, RouterTypes.GROUP, true);

res.send(groupconfig);
} catch (e) {
Expand Down
44 changes: 39 additions & 5 deletions tests/unit-test/verify-ownership.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,19 @@ import {
import { PermissionError } from '../../src/exceptions';

const changePermissionStatus = async (permissionId, status) => {
const permission = await Permission.findById(permissionId);
const permission = await Permission.findById(permissionId).exec();
permission.active = status;
await permission.save();
};

const changePermissionAction = async (permissionId, action) => {
const permission = await Permission.findById(permissionId);
const permission = await Permission.findById(permissionId).exec();
permission.action = action;
await permission.save();
};

const changeTeamStatus = async (teamId, status) => {
const team = await Team.findById(teamId);
const team = await Team.findById(teamId).exec();
team.active = status;
await team.save();
};
Expand Down Expand Up @@ -64,6 +64,11 @@ describe('Success tests', () => {
});

test('UNIT_TEAM_PERMISSION_SUITE - Should allow access - Member has permission to select group', async () => {
// Given
// Enabled Read - Group
await changePermissionStatus(permission2Id, true);

// Test
try {
const element = await verifyOwnership(
adminAccount,
Expand All @@ -78,9 +83,38 @@ describe('Success tests', () => {
}
});

test('UNIT_TEAM_PERMISSION_SUITE - Should allow access - Member has permission to select group - Cascade', async () => {
// Given
// Disabled Read - Group
await changePermissionStatus(permission2Id, false);

// Enabled Read - Config
await changePermissionStatus(permission3Id, true);

// Test
try {
const element = await verifyOwnership(
adminAccount,
groupConfig2Document,
domainDocument,
ActionTypes.READ,
RouterTypes.GROUP,
true);

expect(element._id).toEqual(groupConfig2Document._id);
} catch (e) {
expect(e).toBeNull();
}
});

test('UNIT_TEAM_PERMISSION_SUITE - Should allow access - Member has permission to select just one of those', async () => {
// Given
// Enabled Read - Group
await changePermissionStatus(permission2Id, true);

// Test
try {
let groups = await GroupConfig.find({ domain: domainId });
let groups = await GroupConfig.find({ domain: domainId }).exec();
expect(groups.length).toEqual(2);

const element = await verifyOwnership(
Expand Down Expand Up @@ -161,7 +195,7 @@ describe('Success tests', () => {

expect(element._id).toEqual(configDocument._id);

let groups = await GroupConfig.find({ domain: domainId });
let groups = await GroupConfig.find({ domain: domainId }).exec();
expect(groups.length).toEqual(2);

element = await verifyOwnership(
Expand Down