Skip to content

Closes #443 - Upgrade mongodb driver to 6.0.0 #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Closes #443 - Upgrade mongodb driver to 6.0.0 #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
"helmet": "^7.0.0",
"jsonwebtoken": "^9.0.2",
"moment": "^2.29.4",
"mongodb": "^5.7.0",
"mongoose": "^7.4.0",
"mongodb": "^6.0.0",
"mongoose": "^7.5.0",
"pino": "^8.15.0",
"pino-pretty": "^10.2.0",
"swagger-ui-express": "^5.0.0",
Expand Down
3 changes: 1 addition & 2 deletions src/services/metric.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import moment from 'moment';
import { ObjectId } from 'mongodb';
import { NotFoundError } from '../exceptions';
import { verifyOwnership } from '../helpers';
import { EnvType } from '../models/environment';
Expand Down Expand Up @@ -180,7 +179,7 @@ function buildMetricsFilter(req) {
let args = {};

args.domain = req.query.domainid;
aggregate.match({ domain: new ObjectId(String(req.query.domainid)) });
aggregate.match({ $expr: { $eq: [{ $toString: '$domain' }, args.domain] } });

if (req.query.environment) {
args.environment = req.query.environment;
Expand Down
3 changes: 3 additions & 0 deletions tests/metric.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ describe('Fetch overall statistics', () => {

// Response validation
expect(response.body).not.toBeNull();
expect(response.body.reasons.length > 0).toEqual(true);
expect(response.body.switchers.length > 0).toEqual(true);
expect(response.body.components.length > 0).toEqual(true);
});

test('METRIC_SUITE - Should return only switcher statistics from a given Domain', async () => {
Expand Down