Skip to content

#431 - Fixes Strategy permission verification #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023
Merged

#431 - Fixes Strategy permission verification #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/services/config-strategy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export async function deleteStrategy(id, admin) {
export async function updateStrategy(id, args, admin) {
let configStrategy = await getStrategyById(id);
configStrategy = await verifyOwnership(admin, configStrategy, configStrategy.domain, ActionTypes.UPDATE,
RouterTypes.STRATEGY, configStrategy.activated.keys().next().value);
RouterTypes.STRATEGY, false, configStrategy.activated.keys().next().value);
configStrategy.updatedBy = admin.email;

const updates = Object.keys(args);
Expand All @@ -115,7 +115,7 @@ export async function addVal(id, args, admin) {
}

configStrategy = await verifyOwnership(admin, configStrategy, configStrategy.domain, ActionTypes.UPDATE,
RouterTypes.STRATEGY, configStrategy.activated.keys().next().value);
RouterTypes.STRATEGY, false, configStrategy.activated.keys().next().value);
configStrategy.updatedBy = admin.email;

configStrategy.values.push(value);
Expand Down Expand Up @@ -148,7 +148,7 @@ export async function updateVal(id, args, admin) {
}

configStrategy = await verifyOwnership(admin, configStrategy, configStrategy.domain, ActionTypes.UPDATE,
RouterTypes.STRATEGY, configStrategy.activated.keys().next().value);
RouterTypes.STRATEGY, false, configStrategy.activated.keys().next().value);
configStrategy.updatedBy = admin.email;

configStrategy.values.splice(indexOldValue, 1);
Expand All @@ -170,7 +170,7 @@ export async function removeVal(id, args, admin) {
}

configStrategy = await verifyOwnership(admin, configStrategy, configStrategy.domain, ActionTypes.UPDATE,
RouterTypes.STRATEGY, configStrategy.activated.keys().next().value);
RouterTypes.STRATEGY, false, configStrategy.activated.keys().next().value);
configStrategy.updatedBy = admin.email;

configStrategy.values.splice(indexValue, 1);
Expand Down