Skip to content

Fixes disable metric flag with not active environments #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fixes disable metric flag with not active environments #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/client/resolvers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,11 @@ async function resolveRelay(config, environment, entry, response) {
}

function isMetricDisabled(config, environment) {
if (config.disable_metrics) {
return config.disable_metrics[environment];
if (config.disable_metrics[environment] === undefined) {
return true;
}
return false;

return config.disable_metrics[environment];
}

function checkFlags(config, group, domain, environment) {
Expand Down
16 changes: 5 additions & 11 deletions src/external/switcher-api-facade.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,21 +152,15 @@ export async function checkMetrics(config) {
}

const { owner } = await getDomainById(config.domain);
const response = await getFeatureFlag(SwitcherKeys.ELEMENT_CREATION)
const featureFlag = await getFeatureFlag(SwitcherKeys.ELEMENT_CREATION)
.checkPayload(JSON.stringify({
feature: 'metrics',
owner
})).isItOn();

if (!response.result) {
if (!config.disable_metrics) {
config.disable_metrics = new Map();
config.disable_metrics.set(EnvType.DEFAULT, true);
}

config.activated.forEach((value, key) => {
config.disable_metrics.set(key, true);
});

if (!featureFlag.result) {
config.disable_metrics = new Map();
config.disable_metrics.set(EnvType.DEFAULT, true);
}
}

Expand Down
4 changes: 3 additions & 1 deletion src/models/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ const configSchema = new mongoose.Schema({
},
disable_metrics: {
type: Map,
of: Boolean
of: Boolean,
required: true,
default: new Map().set(EnvType.DEFAULT, false)
},
updatedBy: {
type: String
Expand Down