feat: improved async performance with thread-safe type (#381) #382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



This pull request refactors how the
SwitcherBuilderand its implementationSwitcherRequestmanage the history of executions, improves thread safety, and simplifies several null checks throughout the codebase. The most significant changes include moving thehistoryExecutionmap from the abstract builder to the concrete request class and switching to a thread-safe implementation, as well as updating null checks to useObjects.nonNullandObjects.isNullfor clarity and consistency.Refactoring and Thread Safety
historyExecutionmap fromSwitcherBuildertoSwitcherRequest, and changed its implementation to useConcurrentHashMapfor thread safety. (src/main/java/com/switcherapi/client/model/SwitcherBuilder.java[1] [2];src/main/java/com/switcherapi/client/model/SwitcherRequest.java[3] [4]flush()method inSwitcherBuilderto be abstract, and implemented it inSwitcherRequestto clear bothentryandhistoryExecution. (src/main/java/com/switcherapi/client/model/SwitcherBuilder.java[1];src/main/java/com/switcherapi/client/model/SwitcherRequest.java[2]These changes collectively improve the maintainability, thread safety, and readability of the codebase.
[Before] Operations /s in 5s
[After] Operations /s in 5s