Improved handler to recover from panic issue with malformed snapshots #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances error handling in the
CoreHandlerto recover gracefully from panics in thecomparatorServiceand introduces corresponding tests to ensure robustness. The key changes include adding adeferstatement in thecheckForChangesmethod to handle panics, creating aFakeComparatorServicefor testing, and adding a new test case to verify the behavior when a panic occurs.Error Handling Enhancements:
src/core/handler.go: Updated thecheckForChangesmethod to include adeferblock that recovers from panics in thecomparatorService, ensuring the method returns empty results and an error message when a panic occurs. This prevents crashes due to inconsistent repository data.