Bump apollo-angular@12.1.0, nginx@1.29.2, fixed code smells #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on dependency upgrades, codebase modernization, and minor logic improvements throughout the application. The most significant changes involve updating major dependencies (including Angular and Apollo), replacing global browser references for better compatibility, and refining some logic for clarity and correctness.
Dependency upgrades:
20.3.7, Apollo Client to4.0.7, Apollo Angular to12.1.0, and other dependencies to their latest minor versions inpackage.json.Dockerfilefromnginx:1.29.1-alpine-slimtonginx:1.29.2-alpine-slim.Codebase modernization and browser compatibility:
windowwithglobalThisfor browser APIs (such asinnerWidth,screen, andhistory) across multiple components to improve compatibility and future-proof the code. [1] [2] [3] [4] [5] [6] [7] [8]Logic and code improvements:
.forEachtofor...ofloops for clarity and correctness in several components (ChangelogComponent,ComponentsComponent). [1] [2].filter(...)[0]with.find(...)for more idiomatic and efficient code. [1] [2]ChangelogComponentby switching from.indexOfchecks to.includesand.somefor better readability and reliability. [1] [2]Form and editing logic fixes:
ConfigDetailComponent,RelayDetailComponent,StrategyDetailComponent) to return early when entering edit mode, preventing unintended execution of validation and update logic. [1] [2] [3]ConfigDetailComponent. [1] [2]Type and import corrections:
ElementAutocompleteComponentfromApolloQueryResulttoApollo.QueryResult. [1] [2]