Skip to content

ci(release): fix windows release #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024
+6 −2
Merged

ci(release): fix windows release #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/fix-windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"algohub": patch:fix
---

Fix windows semver compatibility, uses `nsis` only now.
3 changes: 1 addition & 2 deletions .github/workflows/covector-version-or-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
args: ""
target: ""
- platform: "windows-latest"
args: "--target x86_64-pc-windows-msvc"
args: "--target x86_64-pc-windows-msvc --bundles nsis"
target: "x86_64-pc-windows-msvc"

runs-on: ${{ matrix.platform }}
Expand Down Expand Up @@ -141,7 +141,6 @@ jobs:
releaseId: ${{ needs.version-or-publish.outputs.releaseId }}
args: ${{ matrix.args }}
updaterJsonPreferNsis: true
appVersion: 0.1.0-nightly

release-aur:
needs: [release-tauri, version-or-publish]
Expand Down