This repository was archived by the owner on Apr 20, 2025. It is now read-only.
Use utf-8 when reading README.md in setup.py #122
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Here is a small patch which sets encoding to UTF-8 in readme.md reading in setup.py.
On pre-3.7 environments the default encoding may be different than UTF-8. AFAIK that's the case when the system locale is not set. I'm getting UnicodeDecodeError on installing rsa in clean Ubuntu 18.04 environment in Docker.
UTF-8 mode in
openas well as usingio.openis the recommended by pip/pypi authors practice. I used pypi sample projects as a reference (https://github.com/pypa/sampleproject/blob/master/setup.py).