This repository was archived by the owner on Apr 20, 2025. It is now read-only.
Trivial fix on primality testing #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsa/prime.py
Outdated
|
|
||
| x = pow(a, d, n) | ||
| if x == 1 or x == n - 1: | ||
| if x in {1, n - 1}: |
Owner
There was a problem hiding this comment.
Please don't mix code style changes with actual bugfixes. Constructing a set for every test is not a good idea, and might be quite a bit slower than simply having x == 1 or x == n - 1.
adamantike
changed the title
Contributor
Author
|
Fixed! Travis test fails because of 9a9e08c. |
Contributor
Author
|
Test fixed by taking care of |
Owner
|
Merged in f520014, thanks again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsa.randnum.randint(m)generates a random number1 <= x <= m, sorandint(n - 4) + 2returned a value in range[3, n-2]instead of[2, n-2].