Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Apr 30, 2019

Issue: #134

  • Moved filter modification creation out of AccountPropertyTransaction.

  • Modification class is AccountPropertyModification

  • Now support both constructor creation and static method creation.
    new AccountPropertyModification(PropertyModificationType, T)

    or
    
    AccountPropertyModification.createForAddress(PropertyModificationType, Address)
    AccountPropertyModification.createForMosaic(PropertyModificationType, Mosaic)
    AccountPropertyModification.createForEntityType(PropertyModificationType, entityType)
    

@rg911 rg911 requested a review from evias April 30, 2019 18:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 363

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 79.703%

Totals Coverage Status
Change from base Build 352: 0.5%
Covered Lines: 1504
Relevant Lines: 1773

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 363

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 79.703%

Totals Coverage Status
Change from base Build 352: 0.5%
Covered Lines: 1504
Relevant Lines: 1773

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 30, 2019

Pull Request Test Coverage Report for Build 371

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 79.703%

Totals Coverage Status
Change from base Build 370: -0.009%
Covered Lines: 1504
Relevant Lines: 1773

💛 - Coveralls

@rg911 rg911 deleted the task/g134_account_property_enhancement branch June 4, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants