Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Jul 8, 2019

Issue #195

Problem

After updated rxjs to the latest version (run npm update) it throw compile error on all http repositories. Latest version of Rxjs and typescript only support strong typed parameters.

Fixes

  • Update the swagger codegen typescript-node template with correct resolve & reject codes.
  • Update Http repos with strong typed parameters matching the generated swagger codes.
  • Added errorHandling to parse useful error details. (generated swagger code returns the full http response).
  • Tested on current & latest npm packages (after npm update)

@coveralls
Copy link

coveralls commented Jul 8, 2019

Pull Request Test Coverage Report for Build 580

  • 16 of 202 (7.92%) changed or added relevant lines in 15 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 60.472%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/Http.ts 2 4 50.0%
src/infrastructure/api/networkRoutesApi.ts 0 2 0.0%
src/infrastructure/NetworkHttp.ts 4 8 50.0%
src/infrastructure/api/chainRoutesApi.ts 0 4 0.0%
src/infrastructure/api/diagnosticRoutesApi.ts 0 4 0.0%
src/infrastructure/api/nodeRoutesApi.ts 0 4 0.0%
src/infrastructure/api/mosaicRoutesApi.ts 0 6 0.0%
src/infrastructure/api/namespaceRoutesApi.ts 0 8 0.0%
src/infrastructure/api/blockRoutesApi.ts 0 12 0.0%
src/infrastructure/api/transactionRoutesApi.ts 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
src/infrastructure/NamespaceHttp.ts 2 16.07%
src/infrastructure/TransactionHttp.ts 4 25.93%
Totals Coverage Status
Change from base Build 579: -0.3%
Covered Lines: 6362
Relevant Lines: 9093

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants