Elephant 3 Compatible #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Latest schema changes applied - Uint64 string handler added
- Changed account transactions to use Address - Fixed tests
fboucquez
reviewed
Sep 15, 2019
Contributor
fboucquez
left a comment
fboucquez
left a comment
There was a problem hiding this comment.
Hi Steve, I have added several comments. Some are improvements for a future task. Some you may be able to fix in this PR (for example adding a method to centralize how NamespaceId are mapped form a Json field).
| * @returns Observable<Transaction[]> | ||
| */ | ||
| unconfirmedTransactions(publicAccount: PublicAccount, | ||
| unconfirmedTransactions(address: Address, |
Contributor
There was a problem hiding this comment.
Cool, an Address is simpler to create than a PublicAccount. This simplifies the api for the sdk client.
- Fixed createFromEncoded bug
fboucquez
approved these changes
Sep 16, 2019
Contributor
fboucquez
left a comment
fboucquez
left a comment
There was a problem hiding this comment.
Thanks for the latest changes Steve
evias
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressfor allaccountIds (Address | PubKey)for rest endpoint querying. E.g.accountHttp.getTransactions(). Didn't make the parameter optional, as Address class has the factory methods to build from address or publicKeys (Address.createFromRawAddress, Address.createFromPublicKey).check inCosignTransactions` to allow offline aggregateTransaction cosigning.Issue resolved:
#240 #223 #228 #213