Skip to content

Conversation

@jontey
Copy link
Contributor

@jontey jontey commented Dec 5, 2018

No description provided.

Copy link

@Vektrat Vektrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the tests as well

@jontey
Copy link
Contributor Author

jontey commented Dec 5, 2018

@Vektrat Fixed :)

@jontey
Copy link
Contributor Author

jontey commented Dec 5, 2018

@Vektrat Done. Thank you for catching that.

@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 108

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.0%) to 71.44%

Files with Coverage Reduction New Missed Lines %
src/model/namespace/NamespaceId.ts 2 66.67%
src/service/NamespaceService.ts 8 21.43%
Totals Coverage Status
Change from base Build 107: -1.0%
Covered Lines: 751
Relevant Lines: 994

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants