Skip to content

Applied openAPI 0.8.7 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from Mar 10, 2020
Merged

Applied openAPI 0.8.7 #488

merged 8 commits into from Mar 10, 2020

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Mar 10, 2020 •
edited
Loading

  • Added getNetworkProperties endpoint in NetworkRepository
  • Added getRentalFees endpoint in NetworkRepository
  • Changed getNetworkFees to getTransactionFees in NetworkRepository
  • Moved all network related models into network folder
  • Updated typescript version to the latest

Fixed #486

@rg911 rg911 requested review from dgarcia360, evias and fboucquez March 10, 2020 11:28
@fboucquez
Copy link
Contributor

fboucquez commented Mar 10, 2020

@rg911 , rest sends this payload back in the rest endpoint

https://github.com/nemtech/symbol-sdk-java/blob/master/sdk-vertx-client/src/test/resources/json/network-configuration.json

Maybe you can read this file in your unit tests to validate the model are being mapped correctly?

@rg911 rg911 merged commit 41d6c77 into symbol:master Mar 10, 2020
@fboucquez fboucquez deleted the task/g486_open_api_0.8.7 branch April 13, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fboucquez fboucquez Awaiting requested review from fboucquez

@dgarcia360 dgarcia360 Awaiting requested review from dgarcia360

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apply latest OpenAPI specification with new endpoints introduced (0.8.6 - 0.8.7)

3 participants

@rg911 @fboucquez @evias