Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Feb 15, 2019

New hash types added based on newLockHashAlgorithm

Changed default secret lock hash type SHA3_512 to SHA3_256

tests added

@rg911 rg911 self-assigned this Feb 15, 2019
@coveralls
Copy link

coveralls commented Feb 16, 2019

Pull Request Test Coverage Report for Build 123

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.9%) to 71.463%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/transaction/HashType.ts 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
src/model/namespace/NamespaceId.ts 2 66.67%
src/service/NamespaceService.ts 8 21.43%
Totals Coverage Status
Change from base Build 115: -0.9%
Covered Lines: 758
Relevant Lines: 1004

💛 - Coveralls

@rg911 rg911 closed this Feb 16, 2019
@rg911 rg911 reopened this Feb 16, 2019
1. Changed default SHA3_512 to SHA3_256
2. Adding  Op_Keccak_256, Op_Hash_160, Op_Hash_256
@rg911 rg911 deleted the issue/#57_#58 branch March 26, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants