Skip to content

MosaicId and MosaicNonce usability improvement #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 28, 2019
Merged

MosaicId and MosaicNonce usability improvement #68

merged 11 commits into from
Feb 28, 2019

Conversation

@evias
Copy link
Contributor

@evias evias commented Feb 25, 2019

Added

  • Added MosaicNonce unit tests
  • Added MosaicNonce.createRandom()
  • Added MosaicId.createRandom(owner)
  • Added MosaicId.createFromNonce(nonce, owner)

@coveralls
Copy link

coveralls commented Feb 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 160

  • 16 of 29 (55.17%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 70.617%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/mosaic/MosaicId.ts 6 7 85.71%
src/model/mosaic/MosaicNonce.ts 7 8 87.5%
src/model/UInt64.ts 0 3 0.0%
src/infrastructure/NamespaceHttp.ts 1 9 11.11%
Files with Coverage Reduction New Missed Lines %
src/infrastructure/NamespaceHttp.ts 2 20.79%
Totals Coverage Status
Change from base Build 147: -0.5%
Covered Lines: 843
Relevant Lines: 1113
💛 - Coveralls

dgarcia360
dgarcia360 suggested changes Feb 27, 2019
View reviewed changes
dgarcia360
dgarcia360 suggested changes Feb 27, 2019
View reviewed changes
Greg S added 11 commits February 27, 2019 23:08
@evias
Added MosaicNonce tests and MosaicNonce.createRandom() ; Added Mosaic…
d9260e7 
…Id.createRandom()
@evias
fixed missing inclusion of AliasTransaction
1c935de
@evias
PR symbol#68: expose UInt64.fromHex and UInt64.toHex
31ceaa3
@evias
PR symbol#68: removed MosaicId.createRandom() ; Fixed Network(Currenc…
3625e2d 
…y|Harvest)Mosaic to hold NAMESPACE_ID ; Fix MOSAIC_ID references
@evias
PR symbol#68: fix export of MosaicNonce class
6d49d10
@evias
PR symbol#68: removed MosaicId.fullName ; add hexadecimal notation st…
f8a94ff 
…ring initialization
@evias
PR symbol#68: Added versioning explanations and CHANGELOG in README
e0c015d
@evias
PR symbol#68: added throw for invalid namespace query ; fixed MosaicI…
3e0bbe9 
…d and Address types
@evias
lock nem2-library@v0.9.8 for better cow support
fef7581
@evias
add CHANGELOG details about AliasDTO bugfixx
3e3d591
@evias
v0.10.3-0: working NetworkCurrencyMosaic and NamespaceHttp and fixed …
e665bf9 
…Aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dgarcia360 dgarcia360 dgarcia360 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@evias evias

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evias @coveralls @dgarcia360