Skip to content

#44: use LocalDateTime rather than Date for unit test expected data source #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2019
Merged

#44: use LocalDateTime rather than Date for unit test expected data source #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11d0321
#44: use LocalDateTime rather than Date for unit test expected data s…
evias Mar 1, 2019
6616e51
v0.10.3-2: Added Listener.unsubscribeFrom, Fixes for #24, #41, #44
evias Mar 1, 2019
b682980
Merge branch 'master' into task/g44-fix-deadline
evias Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nem2-sdk",
"version": "0.10.3-1",
"version": "0.10.3-2",
"description": "Reactive Nem2 sdk for typescript and javascript",
"scripts": {
"pretest": "npm run build",
Expand Down
15 changes: 10 additions & 5 deletions test/model/transaction/Deadline.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,21 @@
*/

import {expect} from 'chai';
import {ChronoUnit} from 'js-joda';
import {ChronoUnit, Instant, LocalDateTime, ZoneId} from 'js-joda';
import {Deadline} from '../../../src/model/transaction/Deadline';

describe('Deadline', () => {
it('should createComplete timestamp today', () => {
const deadline = Deadline.create();
const date = new Date();
expect(deadline.value.dayOfMonth()).to.be.equal(date.getDate());
expect(deadline.value.monthValue()).to.be.equal(date.getMonth() + 1);
expect(deadline.value.year()).to.be.equal(date.getFullYear());

// avoid SYSTEM and UTC differences
const networkTimeStamp = (new Date()).getTime();
const timestampLocal = LocalDateTime.ofInstant(Instant.ofEpochMilli(networkTimeStamp), ZoneId.SYSTEM);
const reproducedDate = timestampLocal.plus(2, ChronoUnit.HOURS);

expect(deadline.value.dayOfMonth()).to.be.equal(reproducedDate.dayOfMonth());
expect(deadline.value.monthValue()).to.be.equal(reproducedDate.monthValue());
expect(deadline.value.year()).to.be.equal(reproducedDate.year());
});

it('should throw error deadline smaller than timeStamp', () => {
Expand Down