-
Notifications
You must be signed in to change notification settings - Fork 15
Adds SymEngine::symbols() and allows Symbol.new to take a Ruby symbol #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,36 @@ | ||
| module SymEngine | ||
| class << self | ||
|
|
||
| # Defines a shortcut for SymEngine::Symbol.new() allowing multiple symbols | ||
| # to be created all at once. | ||
| # | ||
| # Examples: | ||
| # | ||
| # x, y = SymEngine.symbols(%i{x y}) | ||
| # x, y = SymEngine.symbols(%w{x y}) | ||
| # x, y = SymEngine.symbols([:x, :y]) | ||
| # x, y = SymEngine.symbols(['x', 'y']) | ||
| # x, y = SymEngine.symbols('x', 'y') | ||
| # x, y = SymEngine.symbols('x y') | ||
| # | ||
| def symbols ary_or_string, *params | ||
| # Want to make sure we can accept an array or a bunch of splatted arguments | ||
| if params.size > 0 | ||
| ary_or_string = (ary_or_string.is_a?(String) ? [ary_or_string] : ary_or_string).concat(params) | ||
| elsif ary_or_string.is_a?(String) | ||
| # or accept a string | ||
| ary_or_string = ary_or_string.split | ||
| end | ||
|
|
||
| # Make an Array of SymEngine::Symbols from the parameters we received, | ||
| # now that they're normalized. | ||
| ary_or_string.map do |symbol_or_string| | ||
| SymEngine::Symbol.new(symbol_or_string) | ||
| end | ||
| end | ||
| end | ||
| end | ||
|
|
||
| require 'symengine/symengine' | ||
| require 'symengine/iruby' | ||
| require 'symengine/basic' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you test the following:
Based on your comment above, should we also test these:
I can see that you test
SymEngine::Symbol.new('x')andSymEngine::Symbol.new(:x)below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%i{x y}is the same as[:x, :y], and%w{x y}is the same as['x', 'y'].I suppose we could also be exhaustive and test
SymEngine.symbols(:x, :y), but it follows the same execution path asSymEngine.symbols('x', 'y'), so I think it's redundant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. Then all is good.