Redesign specs style

[zverok]

As per our email discussion.
What is done here:

• redesign of all the specs according to modern RSpec style (subject/let, small contexts, shared examples);
• arit_spec.rb was merged into basic_spec.rb;
• added #inspect to Basic class, as per Add meaningful #inspect to classes #40, for better debugging:
  • before: expected: #<SymEngine::Pow:0xa84e298>, got: #<SymEngine::Add:0xa84e2d4>
  • after: expected: #<SymEngine::Pow(x**y)>, got: #<SymEngine::Add(z)>)
• cleanup of spec_helper.rb and adding new rspec-its gem for shorter matchers.

Hope that helps.

[certik]

@zverok thanks a lot for helping us redesign it!

There are some test failures, are those introduced by this PR? If so, then they need to be fixed.

[zverok]

@certik Oops, I was busy yesterday evening, checked specs only locally (they worked), forgot to re-check at Travis. Will fix tiday.

[abinashmeher999]

@zverok Thanks for taking the time to redesign it!

The specs are shorter and more readable now. In many cases things that you have added, I didn't even know one could do it that way.

As you pointed it out, we need to expose shorter functions for Klass.new methods or do something about the name clashes.

[zverok]

As we are testing against installed gem, and gem files are not including .rspec, we need to specify this directly.

[abinashmeher999]

I see. Since we are already including the spec/ folder, I guess there is no harm in including .rspec too. By the way, should spec/ folder be packaged with the gem?

[zverok]

I'm usually including it :)
And, if we'll look at popular gems, they are typically doing the same thing.
So, I think it is ok (as well as .rspec file inclusion).

[abinashmeher999]

Cool. We can do it after this PR is merged. Let's wait for the tests.

[zverok]

OK, Travis seems happy with current state of the things, and AppVeyor is somehow hanging it for ages. I think, it can be merged (it is really doubtful that specs redesign have broke something only on Windows).

[isuruf]

Thanks for the PR

[abinashmeher999]

Thanks @zverok for the PR!

[zverok]

👍