Exception Handling #64
Conversation
ext/symengine/ruby_basic.c
Outdated
| return result; | ||
| } else { | ||
| basic_free_stack(cbasic_operand2); | ||
| rb_raise(rb_eRuntimeError, "Runtime Error"); |
There was a problem hiding this comment.
What does this error signify? The error message should be more descriptive than "Runtime Error", which does not give much information about what's actually going wrong.
There was a problem hiding this comment.
@v0dro this is in place until a exceptions are made in the SymEngine C++ code (right now it's all std::runtime_errors). Anyway I have written the code to be integrated into the cwrappers to catch multiple exceptions (for a method like parse this is needed). Then depending on the error code sent, the suitable error message will be displayed. This is still WIP. Please check symengine/symengine#1044 for the discussion on this :)
ext/symengine/symengine_utils.c
Outdated
| } else { | ||
| basic_free_stack(cbasic_operand1); | ||
| basic_free_stack(cbasic_operand2); | ||
| rb_raise(rb_eRuntimeError, "Runtime Error"); |
There was a problem hiding this comment.
You should use raise_exception here.
rajithv
force-pushed
the
exception
branch
4 times, most recently
from
45c9334 to
62351d1
Compare
ext/symengine/symengine_utils.c
Outdated
| basic_free_stack(cbasic_operand2); | ||
| int error_code = cwfunc_ptr(cresult, cbasic_operand1, cbasic_operand2); | ||
|
|
||
| if (error_code == 0) { |
There was a problem hiding this comment.
Instead of 0, check for SYMENGINE_NO_EXCEPTION
|
Can you add some tests in ruby? |
ext/symengine/ruby_basic.c
Outdated
| cresult); | ||
| basic_free_stack(cbasic_operand2); | ||
|
|
||
| int error_code = cwfunc_ptr(cresult, this, cbasic_operand2); |
There was a problem hiding this comment.
Try to use the enum for error codes here.
| result = Data_Wrap_Struct(Klass_of_Basic(cresult), NULL, cbasic_free_heap, | ||
| cresult); | ||
|
|
||
| symengine_exceptions_t error_code = cwfunc_ptr(cresult, this); |
There was a problem hiding this comment.
You should use one convention. int or symengine_exceptions_t or CWRAPPER_OUTPUT_TYPE. All 3 are used in this PR.
|
Thanks for the PR. |
4 participants
An example with
cbasic_divmethod.