deprecate DynamicRouter::match and cleanup interface usage #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…possible without BC
There was a problem hiding this comment.
@dawehner i hope this is ok for you? RouterInterface would force the UrlMatcherInterface which makes no sense for a RequestMatcherInterface (symfony 2.0 BC legacy of symfony itself).
this interface was added in 1.3.0-RC1, thus never had a stable release...
|
tests are failing https://travis-ci.org/symfony-cmf/Routing/jobs/36578349#L86 |
|
ping |
lsmith77
added a commit
that referenced
this pull request
Oct 3, 2014
deprecate DynamicRouter::match and cleanup interface usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as far as possible without BC
An alternative to #116 without BC breaks for a released version. Once merged, i will update #116 as there will be conflicts - it has to stay open until we do a 2.0 version of this library.