extract route enhancer into trait #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Jan 31, 2017
CHANGELOG.md
Outdated
| ========= | ||
|
|
||
| 2.0.0 (unreleased) | ||
| ------------------ |
There was a problem hiding this comment.
please remove the header from the CHANGELOG file in dev. Adding the header is part of the release checklist.
dbu
force-pushed
the
separate-enhancer-trait
branch
from
b05cd7a to
01fb2d9
Compare
dbu
force-pushed
the
separate-enhancer-trait
branch
from
01fb2d9 to
0cb2f53
Compare
|
rebased to get your fix in, and fixed the changelog |
|
Looks all but identical. I swapped out my temporary version of this and ran tests, 100% passes. |
|
excellent! we will release 2.0 stable in the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #155