test current symfony versions #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ElectricMaxxx so there seems to be some regression with symfony 4.1 according to the test matrix. maybe you should discuss the ticket you created with this PR, as it shows since when the problem appears. looking at https://github.com/symfony/symfony/blob/master/CHANGELOG-4.1.md there are a bunch of changes to routing matching (the thing about compiling a regular expression could be the culprit, or one of the things about trailing slash possibly)? |
dbu
force-pushed
the
test-with-symfony-41-42
branch
from
a9886f5 to
9470f40
Compare
dbu
force-pushed
the
test-with-symfony-41-42
branch
from
9470f40 to
132cd07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we claim to work with those versions, lets see if that is true.