fix passing route object parameter to generator

[gseidel]

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
License	MIT

If the route is fetched over a relation from the database, it could be, that the route is still a proxy object (For lazy loading). If a url is generated with a proxy route object, then symfony will generate a string like /path?_route_object%5B__isInitialized__%5D=1, because http_build_query also accept objects and generate a value if the object has a public property.

I think the parameter RouteObjectInterface::ROUTE_OBJECT is not necessary to pass it doGenerate. So it should be unset if exists.

[dbu]

thanks a lot, good point!

is this the only point where we need to do this, or are there other places in the code? i guess whenever we read the route from the ROUTE_OBJECT parameter potentially has the same issue.

[dbu]

to avoid any possible side effects, i would move this into the elseif right after line 67.

[gseidel]

Good point. I updated the code and use it inside the elseif

[dbu]

thanks!

i double checked and only found ContentAwareGenerator where we use the ROUTE_OBJECT as well, and that calls the parent generate method which is what you are fixing here. so we are good 👍

[dbu]

i updated the changelog and tagged 2.3.2 with this.

[gseidel]

Thanks a lot @dbu