Skip to content

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Jan 16, 2021

Q A
Branch? "master"
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

See CI in https://github.com/alexander-schranz/Routing/pull/1/checks

Requires:

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to restart after symfony-cmf/Testing#208

@dbu
Copy link
Member

dbu commented Jan 22, 2021

hm, adding the star seems to have broken the build matrix. do you see whats wrong?

with the next push, testing should be available for php 8

@alexander-schranz
Copy link
Contributor Author

hm, adding the star seems to have broken the build matrix. do you see whats wrong?

I don't know tried the same and just the builds are then away. Looks for me more like a bug in github action itself. I think we need to remove the star.

@alexander-schranz
Copy link
Contributor Author

Also tests green again: https://github.com/alexander-schranz/Routing/pull/1/checks

@dbu dbu merged commit fcd37f9 into symfony-cmf:master Jan 22, 2021
@dbu
Copy link
Member

dbu commented Jan 22, 2021

thanks!

@alexander-schranz alexander-schranz deleted the feature/github-actions branch January 23, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants