Skip to content

with doctrine, the routes are probably a Collection. reset() on a collection does not work #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2013
Merged

with doctrine, the routes are probably a Collection. reset() on a collection does not work #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ContentAwareGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Symfony\Cmf\Component\Routing;

use Doctrine\Common\Collections\Collection;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ok to use and to check instanceof a not existing class so this adds no new dependency.

use Symfony\Component\Routing\Route as SymfonyRoute;
use Symfony\Component\Routing\Exception\RouteNotFoundException;
use Symfony\Component\Routing\RouteCollection;
Expand Down Expand Up @@ -181,7 +182,11 @@ protected function getRouteByContent($name, &$parameters)
return $route;
}

// if none matched, continue and randomly return the first one
// if none matched, randomly return the first one
if ($routes instanceof Collection) {
return $routes->first();
}

return reset($routes);
}

Expand Down