Adding MenuOptionsInterface to the Page document class #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2014 13:47
For compatibility with MenuNodeHtmlAttributeExtension from the menuBundle
There was a problem hiding this comment.
this interface does not exist .. is this the correct namespace?
There was a problem hiding this comment.
it is being added in symfony-cmf/menu-bundle#197 , i added that info to the PR description
There was a problem hiding this comment.
then we also need to bump the MenuBundle version in the composer.json
|
okay, i merged symfony-cmf/menu-bundle#197 and restarted the test. @mkoosej can you update composer.json to require menu bundle 1.2 instead of 1.1? and please check where we can add a note about the admin extension in the simple cms bundle doc. |
dbu
added a commit
that referenced
this pull request
Aug 12, 2014
Adding MenuOptionsInterface to the Page document class
|
and green! thanks. can you update the doc PR for menu to also mention this in the simple cms admin doc? |
|
Sure. I'll find a place for it in the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on symfony-cmf/menu-bundle#197