This repository was archived by the owner on Sep 16, 2021. It is now read-only.
add MenuOptionsInterface docs #536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoosej
commented
Aug 12, 2014
mkoosej
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | dev |
| Fixed tickets | symfony-cmf/menu-bundle#197 |
There was a problem hiding this comment.
the tag line (the line containing -) should be as long as the headline (the line containing the text of the headline). In this case, you have to remove some -'s.
There was a problem hiding this comment.
I don't know exactly what you mean but I'll remove it :)
|
I've added some minor comments. If you've fixed these, it can be merged once the code PR is merged. Thank you for documenting your PR, that saves us a lot of time :) |
This was referenced Aug 12, 2014
|
thanks a lot @mkoosej ! i merged the code. i added the PR doc block. i think this needs to be merged to dev, not master as its about the upcoming 1.2 version. |
|
closing in favor of #537 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.