-
Notifications
You must be signed in to change notification settings - Fork 45
[WIP] clean up #19
[WIP] clean up #19
Conversation
composer.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should remain at 1.2
related symfony-cmf/menu-bundle#206 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this meant to be commited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 this breaks HTML indentation
Sorry, but I don't agree with any change you made here to be honest. This is just a fork of the core SE and we only do PRs here for things that are custom to the CMF. Well, there is one change that is correct: changing the branch alias. If you can remove anything else from this PR, it's ready to merge. |
closing for the same reasons as PR in menu bundle |
Sent using Gush