Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Conversation

cordoval
Copy link

Q A
Bug Fix? n
New Feature? n
BC Breaks? n
Deprecations? n
Tests Pass? n
Fixed Tickets
License MIT
Doc PR

Sent using Gush

@cordoval cordoval changed the title bootstrap some changes [WIP] clean up Aug 20, 2014
composer.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should remain at 1.2

@cordoval
Copy link
Author

related symfony-cmf/menu-bundle#206

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this meant to be commited?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it should be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 this breaks HTML indentation

@wouterj
Copy link
Member

wouterj commented Aug 29, 2014

Sorry, but I don't agree with any change you made here to be honest. This is just a fork of the core SE and we only do PRs here for things that are custom to the CMF.

Well, there is one change that is correct: changing the branch alias. If you can remove anything else from this PR, it's ready to merge.

@cordoval
Copy link
Author

closing for the same reasons as PR in menu bundle

@cordoval cordoval closed this Aug 29, 2014
@lsmith77
Copy link
Member

the branch alias is handled in #18

fixed the use statements in 7f345e1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants