Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gush.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
adapter: github
issue-tracker: github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this meant to be commited?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it should be removed

17 changes: 9 additions & 8 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
language: php

php:
- 5.3
- 5.4
# - 5.3
# - 5.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

- 5.5
- hhvm
# - hhvm

matrix:
allow_failures:
- php: hhvm
#matrix:
# allow_failures:
# - php: hhvm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?


before_script:
- composer self-update
Expand All @@ -21,5 +21,6 @@ before_script:
script: phpunit -c app

notifications:
irc: "irc.freenode.org#symfony-cmf"
email: "symfony-cmf-devs@googlegroups.com"
# irc: "irc.freenode.org#symfony-cmf"
# email: "symfony-cmf-devs@googlegroups.com"
email: "cordoval@gmail.com"
12 changes: 6 additions & 6 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
}
],
"autoload": {
"psr-0": { "": "src/" }
"psr-4": { "Acme\\DemoBundle\\": "src/" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am -1 on this. the idea is that people start their own projects from this. they should add their own code in src, with vendor name and bundle name. psr-4 is the right thing for a standalone bundle, but not for the src/ folder of an application.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 too, we are a fork of the core SE, we always follow their changes and do not customize it ourself. (except from CMF custom stuff of course)

},
"minimum-stability": "stable",
"minimum-stability": "dev",
"require": {
"php": ">=5.3.3",
"symfony/symfony": "2.3.*",
Expand All @@ -25,9 +25,9 @@
"symfony/assetic-bundle": "2.3.*",
"symfony/swiftmailer-bundle": "2.3.*",
"symfony/monolog-bundle": "2.3.*",
"symfony-cmf/symfony-cmf": "1.1.*",
"symfony-cmf/simple-cms-bundle": "1.1.*",
"symfony-cmf/create-bundle": "1.1.*",
"symfony-cmf/symfony-cmf": "1.2.*",
"symfony-cmf/simple-cms-bundle": "1.2.*",
"symfony-cmf/create-bundle": "1.2.*",
"sensio/distribution-bundle": "2.3.*",
"sensio/framework-extra-bundle": "2.3.*",
"sensio/generator-bundle": "2.3.*",
Expand Down Expand Up @@ -65,7 +65,7 @@
"file": "app/config/parameters.yml"
},
"branch-alias": {
"dev-master": "1.1-dev"
"dev-master": "1.2-dev"
}
}
}
8 changes: 0 additions & 8 deletions src/Acme/DemoBundle/Resources/views/Block/unit.html.twig

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@

namespace Acme\DemoBundle\Document;

use Sonata\BlockBundle\Block\BlockContextInterface;
use Symfony\Cmf\Bundle\BlockBundle\Doctrine\Phpcr\AbstractBlock;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\OptionsResolver\OptionsResolverInterface;
use Doctrine\ODM\PHPCR\Mapping\Annotations as PHPCR;

/**
Expand Down
8 changes: 8 additions & 0 deletions src/Resources/views/Block/unit.html.twig
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{% extends sonata_block.templates.block_base %}

{% block block %}
<div class="col-md-4 col-sm-4">
<img class="center-block" src="{{ asset(block.image) }}"><br>
<a class="btn btn-default btn-block" href="{{ block.url is not null ? block.url : path(block.route) }}">{{ block.text }}</a>
</div>
{% endblock %}
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{% extends 'AcmeDemoBundle::layout.html.twig' %}

{% block hero_unit %}
<div class="jumbotron page__hero-unit">
<h1>Welcome!</h1>
<h2>Symfony2 Content Management Framework</h2>
</div>
<div class="jumbotron page__hero-unit">
<h1>Welcome!</h1>
<h2>Symfony2 Content Management Framework</h2>
</div>
{% endblock %}

{% block main %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
<title>{% block title %}Demo Bundle{% endblock %}</title>

{% block stylesheets %}
<link href="{{ asset('bundles/acmedemo/css/bootstrap.min.css') }}" rel="stylesheet">
<link href="{{ asset('bundles/acmedemo/css/demo.css') }}" rel="stylesheet">
<link href="{{ asset('bundles/acmedemo/css/bootstrap.min.css') }}" rel="stylesheet">
<link href="{{ asset('bundles/acmedemo/css/demo.css') }}" rel="stylesheet">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 this breaks HTML indentation

{% endblock %}

{# CreateJS is only available for admins by default #}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,3 @@ public function testDemoPage()
$this->assertCount(1, $crawler->filter(sprintf('body:contains("%s")', $body)), 'Page does not contain the text: '.$body);
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ public function setUp()
return;
}

$this->loadFixtures(array(
'Acme\DemoBundle\DataFixtures\PHPCR\LoadDemoData',
), null, 'doctrine_phpcr');
$this->loadFixtures(
array('Acme\DemoBundle\DataFixtures\PHPCR\LoadDemoData'),
null,
'doctrine_phpcr'
);

self::$fixturesLoaded = true;
}
Expand Down