-
Notifications
You must be signed in to change notification settings - Fork 45
[WIP] clean up #19
[WIP] clean up #19
Changes from all commits
025f0da
c392dfa
8c16035
25a62e4
400eb59
9279d74
5e9faa8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
adapter: github | ||
issue-tracker: github | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
language: php | ||
|
||
php: | ||
- 5.3 | ||
- 5.4 | ||
# - 5.3 | ||
# - 5.4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
- 5.5 | ||
- hhvm | ||
# - hhvm | ||
|
||
matrix: | ||
allow_failures: | ||
- php: hhvm | ||
#matrix: | ||
# allow_failures: | ||
# - php: hhvm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
|
||
before_script: | ||
- composer self-update | ||
|
@@ -21,5 +21,6 @@ before_script: | |
script: phpunit -c app | ||
|
||
notifications: | ||
irc: "irc.freenode.org#symfony-cmf" | ||
email: "symfony-cmf-devs@googlegroups.com" | ||
# irc: "irc.freenode.org#symfony-cmf" | ||
# email: "symfony-cmf-devs@googlegroups.com" | ||
email: "cordoval@gmail.com" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,9 +11,9 @@ | |
} | ||
], | ||
"autoload": { | ||
"psr-0": { "": "src/" } | ||
"psr-4": { "Acme\\DemoBundle\\": "src/" } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i am -1 on this. the idea is that people start their own projects from this. they should add their own code in src, with vendor name and bundle name. psr-4 is the right thing for a standalone bundle, but not for the src/ folder of an application. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. -1 too, we are a fork of the core SE, we always follow their changes and do not customize it ourself. (except from CMF custom stuff of course) |
||
}, | ||
"minimum-stability": "stable", | ||
"minimum-stability": "dev", | ||
"require": { | ||
"php": ">=5.3.3", | ||
"symfony/symfony": "2.3.*", | ||
|
@@ -25,9 +25,9 @@ | |
"symfony/assetic-bundle": "2.3.*", | ||
"symfony/swiftmailer-bundle": "2.3.*", | ||
"symfony/monolog-bundle": "2.3.*", | ||
"symfony-cmf/symfony-cmf": "1.1.*", | ||
"symfony-cmf/simple-cms-bundle": "1.1.*", | ||
"symfony-cmf/create-bundle": "1.1.*", | ||
"symfony-cmf/symfony-cmf": "1.2.*", | ||
"symfony-cmf/simple-cms-bundle": "1.2.*", | ||
"symfony-cmf/create-bundle": "1.2.*", | ||
"sensio/distribution-bundle": "2.3.*", | ||
"sensio/framework-extra-bundle": "2.3.*", | ||
"sensio/generator-bundle": "2.3.*", | ||
|
@@ -65,7 +65,7 @@ | |
"file": "app/config/parameters.yml" | ||
}, | ||
"branch-alias": { | ||
"dev-master": "1.1-dev" | ||
"dev-master": "1.2-dev" | ||
} | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{% extends sonata_block.templates.block_base %} | ||
|
||
{% block block %} | ||
<div class="col-md-4 col-sm-4"> | ||
<img class="center-block" src="{{ asset(block.image) }}"><br> | ||
<a class="btn btn-default btn-block" href="{{ block.url is not null ? block.url : path(block.route) }}">{{ block.text }}</a> | ||
</div> | ||
{% endblock %} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,8 +6,8 @@ | |
<title>{% block title %}Demo Bundle{% endblock %}</title> | ||
|
||
{% block stylesheets %} | ||
<link href="{{ asset('bundles/acmedemo/css/bootstrap.min.css') }}" rel="stylesheet"> | ||
<link href="{{ asset('bundles/acmedemo/css/demo.css') }}" rel="stylesheet"> | ||
<link href="{{ asset('bundles/acmedemo/css/bootstrap.min.css') }}" rel="stylesheet"> | ||
<link href="{{ asset('bundles/acmedemo/css/demo.css') }}" rel="stylesheet"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. -1 this breaks HTML indentation |
||
{% endblock %} | ||
|
||
{# CreateJS is only available for admins by default #} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this meant to be commited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it should be removed