Allow custom node icons #120
Conversation
|
Example: symfony-cmf/cmf-sandbox#347 |
wouterj
force-pushed
the
issue-75/custom-icons
branch
from
f42b5e9 to
c0513a8
Compare
| $class = $this->classMap[$class]; | ||
| } | ||
|
|
||
| $description->set('icon', $this->iconMap[$class]); |
There was a problem hiding this comment.
What is an icon in this context? A CSS class or an image?
There was a problem hiding this comment.
Both are allowed in fancytree
There was a problem hiding this comment.
for context, I am currently doing this:
Whereby the "image" is added to the description from any image mappings for the (resource) in the content-type component and subsequently used as the thumbnail via. an imagine resize.
There was a problem hiding this comment.
I think what I am trying to ask is if we can use a standard descriptor here rather than one specific to this bundle? i.e. if I were to swap the above browser for the fancy-tree browser it would be good if they would use the same icons / images.
There was a problem hiding this comment.
can we somehow define this? or have a icon css class enhancer and a icon image enhancer? i guess the css class is good for e.g. image maps?
how does fancytree see whether its a class or an image url?
|
@wouterj Also not sure if you have seen my post to the CMF mailinglist, but I want to split the Resource Descriptor thing out of Resource and into its own repository that is not dependant on resource: https://github.com/dantleech/description |
|
i restarted the PR build after merging the PR on resource-rest |
wouterj
force-pushed
the
issue-75/custom-icons
branch
from
c0513a8 to
b37894f
Compare
|
Ready to be merged |
|
can you fix the year in the configuration class please? (styleci). apart from that i think we can merge this. if you can add some comments in the code aboit image url vs css class, i would appreciate it. |
wouterj
force-pushed
the
issue-75/custom-icons
branch
from
b37894f to
2c2a77b
Compare
4 participants
This allows to configure icons for specific node classes, so each type of node can have its own icon.
Depends on
/fixes #75