This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Use unique keys and avoid duplicated or false nodes #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9a391e9.
ElectricMaxxx
approved these changes
Jan 7, 2017
|
cool! 👍 |
|
You have seen it working i.e. in sandbox? |
|
As the get |
ElectricMaxxx
suggested changes
Jan 7, 2017
There was a problem hiding this comment.
all the karma tests are failing localy, can you fix that please
PhantomJS 1.9.8 (Linux 0.0.0) The Fancytree adapter automatically expands nodes when root is one folder FAILED
TypeError: 'null' is not an object (evaluating 'tree.getNodeByKey('cms').isExpanded')
|
Added In other words: ready to merge imo |
ElectricMaxxx
approved these changes
Jan 28, 2017
|
@wouterj you can merge from my POV, but i don't really understand the one failing build, seems as one before you last commit. |
Closed
|
I wil merge and have a look into the next issue. |
|
@ElectricMaxxx failing build is probably a bug on Travis's side. No problem here for us. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #128, symfony-cmf/sonata-phpcr-admin-integration-bundle#73
/replaces #125
Instead of building the path using keys, the path is now saved in a
refPathdata property per node. This fixes the issue with unique keys (#128). It also makes it easier to fix false or duplicated nodes./cc @ElectricMaxxx