[WIP] Clean up JavaScript scripts

[wouterj]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#5
License	MIT
Doc PR	-

Todo

• Rename files
• Update CS
  • admintree.js
  • selecttree.js
• Add default values
  • admintree.js
  • selecttree.js
• Concat name on 18th character and show full name in tooltip
• Do not show link if not editable

[wouterj]

this are all options. null should get replaced with their default value.

[dbu]

is this a note to yourself? if these where previously undefined when not configured, we might simply validate and throw better errors. for some, there are sensible defaults for sure, but the ajax section for example does not have any sensible defaults.

[lsmith77]

@wouterj do you have time before lunch to fix this up?

[wouterj]

@lsmith77 no, sorry. I'm pretty bussy the last week. I think it's safe to merge this PR if it's really needed, AFAICS nothing of the logic is changed.

[dbu]

as far as i can tell, its cleanup and no important fixes. so i'd prefer to not merge and wait until it really is clean. adding the initializing with null worries me as i don't really understand the implications.

[dbu]

@wouterj is there a part of this that we can merge this weekend? i am still worried by the null initialization as i don't know what it means...

[wouterj]

I've reverted the defaults and updated the CS for the select_tree. Let's merge this now (if it's ok) and after that, I'll try to submit a fix for the bugs this weekend

[dbu]

i am +1 to merge this in. did you test it in the sandbox and things still work?

/cc @lsmith77

[wouterj]

no, didn't test it (only linted it). I'll do it this afternoon on the sandbox.

[wouterj]

tested it and I can't find any problems