chore(deps): removal of doctrine/annotations from dev dependencies

Author: Rastusik

composer.json

@@ -46,7 +46,6 @@
     "require-dev": {
         "ext-ffi": "^8.1",
         "blackfire/php-sdk": "^1.30",
-        "doctrine/annotations": "^1.13",
         "doctrine/dbal": "^3.4",
         "doctrine/doctrine-bundle": "^2.7",
         "doctrine/doctrine-migrations-bundle": "^3.2.4",

composer.lock

@@ -21,5 +21,4 @@ parameters:
 
         # Symfony configuration files
         - '#Variable \$container might not be defined#'
-        - '#Attribute class Symfony\\Component\\Routing\\Attribute\\Route does not exist\.#'
     tmpDir: /tmp/phpstan_tests

phpstan.tests.neon

@@ -1,13 +1,4 @@
 {
-    "doctrine/annotations": {
-        "version": "1.14",
-        "recipe": {
-            "repo": "github.com/symfony/recipes",
-            "branch": "main",
-            "version": "1.10",
-            "ref": "64d8583af5ea57b7afa4aba4b159907f3a148b05"
-        }
-    },
     "doctrine/doctrine-bundle": {
         "version": "2.10",
         "recipe": {

symfony.lock

@@ -50,13 +50,13 @@ public function testOpcacheBlacklistFileGeneration(array $options): void
     }
 
     /**
-     * @param array<array<array{
+     * @param array{
      *    APP_ENV: string,
      *    APP_DEBUG: string,
      *    WORKER_COUNT: string,
      *    REACTOR_COUNT: string,
      *    OVERRIDE_PROD_ENV?: string,
-     *  }>> $envs
+     *  } $envs
      */
     #[DataProvider('coroutineTestDataProvider')]
     public function testCoroutinesWithEnvs(array $envs): void
@@ -136,13 +136,13 @@ public function testCoroutinesWithEnvs(array $envs): void
     }
 
     /**
-     * @param array<array<array{
+     * @param array{
      *    APP_ENV: string,
      *    APP_DEBUG: string,
      *    WORKER_COUNT: string,
      *    REACTOR_COUNT: string,
      *    OVERRIDE_PROD_ENV?: string,
-     *  }>> $envs
+     *  } $envs
      */
     #[DataProvider('coroutineTestDataProvider')]
     public function testCoroutinesAndDoctrineWithEnvs(array $envs): void
@@ -247,13 +247,13 @@ public function testCoroutinesAndDoctrineWithEnvs(array $envs): void
     }
 
     /**
-     * @param array<array<array{
+     * @param array{
      *    APP_ENV: string,
      *    APP_DEBUG: string,
      *    WORKER_COUNT: string,
      *    REACTOR_COUNT: string,
      *    OVERRIDE_PROD_ENV?: string,
-     *  }>> $envs
+     *  } $envs
      */
     #[DataProvider('coroutineTestDataProvider')]
     public function testCoroutinesAndAdvancedDoctrineWithEnvs(array $envs): void
@@ -342,14 +342,14 @@ public function testCoroutinesAndAdvancedDoctrineWithEnvs(array $envs): void
     }
 
     /**
-     * @param array<array<array{
+     * @param array{
      *    APP_ENV: string,
      *    APP_DEBUG: string,
      *    WORKER_COUNT: string,
      *    REACTOR_COUNT: string,
      *    TASK_WORKER_COUNT: string,
      *    OVERRIDE_PROD_ENV?: string,
-     *  }>> $envs
+     *  } $envs
      */
     #[DataProvider('coroutineTestDataProviderForTaskWorkers')]
     public function testCoroutinesAndTaskWorkersWithEnvs(array $envs): void
@@ -421,14 +421,14 @@ public function testCoroutinesAndTaskWorkersWithEnvs(array $envs): void
     }
 
     /**
-     * @param array<array<array{
+     * @param array{
      *    APP_ENV: string,
      *    APP_DEBUG: string,
      *    WORKER_COUNT: string,
      *    REACTOR_COUNT: string,
      *    TASK_WORKER_COUNT: string,
      *    OVERRIDE_PROD_ENV?: string,
-     *  }>> $envs
+     *  } $envs
      */
     #[DataProvider('coroutineTestDataProviderForTaskWorkers')]
     public function testCoroutinesWithTaskWorkersWithDoctrine(array $envs): void

tests/Feature/SwooleServerCoroutinesTest.php

@@ -8,16 +8,11 @@
 use Exception;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route as RouteAnnotation;
-use Symfony\Component\Routing\Attribute\Route;
+use Symfony\Component\Routing\Annotation\Route;
 
 final class BlackfireController
 {
     /**
-     * @RouteAnnotation(
-     *     methods={"GET"},
-     *     path="/blackfire/index"
-     * )
      * @throws Exception
      */
     #[Route(path: '/blackfire/index', methods: ['GET'])]

tests/Fixtures/Symfony/TestBundle/Controller/BlackfireController.php

@@ -10,16 +10,11 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Messenger\MessageBusInterface;
-use Symfony\Component\Routing\Annotation\Route as RouteAnnotation;
-use Symfony\Component\Routing\Attribute\Route;
+use Symfony\Component\Routing\Annotation\Route;
 
 final class CoroutinesTaskController
 {
     /**
-     * @RouteAnnotation(
-     *     methods={"GET","POST"},
-     *     path="/coroutines/message/sleep-and-append"
-     * )
      * @throws Exception
      */
     #[Route(path: '/coroutines/message/sleep-and-append', methods: ['GET', 'POST'])]
@@ -35,13 +30,9 @@ public function dispatchSleepAndAppendMessage(MessageBusInterface $bus, Request
     }
 
     /**
-     * @RouteAnnotation(
-     *     methods={"GET","POST"},
-     *     path="/coroutines/message/run-dummy"
-     * )
      * @throws Exception
      */
-    #[Route(methods: ['GET', 'POST'], path: '/coroutines/message/run-dummy')]
+    #[Route(path: '/coroutines/message/run-dummy', methods: ['GET', 'POST'])]
     public function dispatchRunDummyMessage(MessageBusInterface $bus): Response
     {
         $message = new RunDummy();

tests/Fixtures/Symfony/TestBundle/Controller/CoroutinesTaskController.php

@@ -11,8 +11,7 @@
 use Symfony\Bridge\Doctrine\Middleware\Debug\DebugDataHolder;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Routing\Annotation\Route as RouteAnnotation;
-use Symfony\Component\Routing\Attribute\Route;
+use Symfony\Component\Routing\Annotation\Route;
 
 final class DoctrineController
 {
@@ -27,12 +26,6 @@ public function __construct(
         private readonly ?DebugDataHolder $dataHolder = null,
     ) {}
 
-    /**
-     * @RouteAnnotation(
-     *     methods={"GET"},
-     *     path="/doctrine"
-     * )
-     */
     #[Route(path: '/doctrine', methods: ['GET'])]
     public function index(): Response
     {
@@ -47,12 +40,6 @@ public function index(): Response
         return new Response('<html><body>' . $testsStr . '</body></html>');
     }
 
-    /**
-     * @RouteAnnotation(
-     *     methods={"GET"},
-     *     path="/doctrine-advanced"
-     * )
-     */
     #[Route(path: '/doctrine-advanced', methods: ['GET'])]
     public function advancedUsage(): JsonResponse
     {
@@ -65,24 +52,12 @@ public function advancedUsage(): JsonResponse
         ]);
     }
 
-    /**
-     * @RouteAnnotation(
-     *     methods={"GET"},
-     *     path="/doctrine-queries"
-     * )
-     */
     #[Route(path: '/doctrine-queries', methods: ['GET'])]
     public function queries(): JsonResponse
     {
         return new JsonResponse($this->dataHolder->getData()['default']);
     }
 
-    /**
-     * @RouteAnnotation(
-     *     methods={"GET"},
-     *     path="/doctrine-resets"
-     * )
-     */
     #[Route(path: '/doctrine-resets', methods: ['GET'])]
     public function pings(): JsonResponse
     {

tests/Fixtures/Symfony/TestBundle/Controller/DoctrineController.php

@@ -6,19 +6,12 @@
 
 use SwooleBundle\SwooleBundle\Tests\Fixtures\Symfony\TestBundle\EventHandler\LifecycleEventsEventHandler;
 use Symfony\Component\HttpFoundation\JsonResponse;
-use Symfony\Component\Routing\Annotation\Route as RouteAnnotation;
-use Symfony\Component\Routing\Attribute\Route;
+use Symfony\Component\Routing\Annotation\Route;
 
 final class EventsController
 {
     public function __construct(private readonly LifecycleEventsEventHandler $eventHandler) {}
 
-    /**
-     * @RouteAnnotation(
-     *     methods={"GET"},
-     *     path="/list-events"
-     * )
-     */
     #[Route(path: '/list-events', methods: ['GET'])]
     public function listEvents(): JsonResponse
     {

tests/Fixtures/Symfony/TestBundle/Controller/EventsController.php

@@ -6,29 +6,16 @@
 
 use co;
 use Symfony\Component\HttpFoundation\JsonResponse;
-use Symfony\Component\Routing\Annotation\Route as RouteAnnotation;
-use Symfony\Component\Routing\Attribute\Route;
+use Symfony\Component\Routing\Annotation\Route;
 
 final class IndexController
 {
-    /**
-     * @RouteAnnotation(
-     *     methods={"GET"},
-     *     path="/"
-     * )
-     */
     #[Route(path: '/', methods: ['GET'])]
     public function index(): JsonResponse
     {
         return new JsonResponse(['hello' => 'world!'], 200);
     }
 
-    /**
-     * @RouteAnnotation(
-     *     methods={"GET"},
-     *     path="/dummy-sleep"
-     * )
-     */
     #[Route(path: '/dummy-sleep', methods: ['GET'])]
     public function sleep(): JsonResponse
     {