Skip to content

Conversation

@lochmueller
Copy link
Contributor

@lochmueller lochmueller commented Nov 27, 2025

Q A
Bug fix? no
New feature? feature
Docs? no
Issues Fix #998
License MIT
  • Change StoreInterface
  • Use iterable and yield (and yield from) for all storages
  • Use iterator_to_array for existing test cases

Refs: #998

@carsonbot carsonbot added Bug Something isn't working Status: Needs Review labels Nov 27, 2025
@carsonbot carsonbot changed the title feat: Change StoreInterface from array to iterable feat: Change StoreInterface from array to iterable Nov 27, 2025
@lochmueller lochmueller changed the title feat: Change StoreInterface from array to iterable [Store] Change StoreInterface from array to iterable Nov 27, 2025
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, @chr-hertel and @Guikingone please check as well, thanks

@carsonbot carsonbot changed the title [Store] Change StoreInterface from array to iterable Change StoreInterface from array to iterable Nov 28, 2025
@Guikingone
Copy link
Contributor

Looks good to me 👍🏻

@lochmueller lochmueller changed the title Change StoreInterface from array to iterable [Store] Change StoreInterface from array to iterable Nov 28, 2025
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@chr-hertel chr-hertel force-pushed the feature/store-query-iterable branch from 852ce58 to d615486 Compare November 29, 2025 10:48
@chr-hertel chr-hertel removed the Bug Something isn't working label Nov 29, 2025
@carsonbot carsonbot changed the title [Store] Change StoreInterface from array to iterable Change StoreInterface from array to iterable Nov 29, 2025
@chr-hertel
Copy link
Member

Thank you @lochmueller.

@chr-hertel chr-hertel merged commit 56689f0 into symfony:main Nov 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Store] Change StoreInterface to Iterator

5 participants