Skip to content

[Agent][Platform] Add Metadata to MessageBag #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2025
Merged

[Agent][Platform] Add Metadata to MessageBag #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/agent/tests/StructuredOutput/AgentProcessorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
use Symfony\AI\Fixtures\StructuredOutput\Step;
use Symfony\AI\Platform\Capability;
use Symfony\AI\Platform\Message\MessageBag;
use Symfony\AI\Platform\Metadata\Metadata;
use Symfony\AI\Platform\Model;
use Symfony\AI\Platform\Result\Metadata\Metadata;
use Symfony\AI\Platform\Result\ObjectResult;
use Symfony\AI\Platform\Result\TextResult;
use Symfony\Component\Serializer\SerializerInterface;
Expand Down
4 changes: 4 additions & 0 deletions src/platform/src/Message/MessageBag.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,17 @@

namespace Symfony\AI\Platform\Message;

use Symfony\AI\Platform\Metadata\MetadataAwareTrait;

/**
* @final
*
* @author Christopher Hertel <mail@christopher-hertel.de>
*/
class MessageBag implements MessageBagInterface
{
use MetadataAwareTrait;

/**
* @var list<MessageInterface>
*/
Expand Down
4 changes: 4 additions & 0 deletions src/platform/src/Message/MessageBagInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

namespace Symfony\AI\Platform\Message;

use Symfony\AI\Platform\Metadata\Metadata;

/**
* @author Oskar Stark <oskarstark@googlemail.com>
*/
Expand All @@ -36,4 +38,6 @@ public function prepend(MessageInterface $message): self;
public function containsAudio(): bool;

public function containsImage(): bool;

public function getMetadata(): Metadata;
}
2 changes: 1 addition & 1 deletion ...platform/src/Result/Metadata/Metadata.php → src/platform/src/Metadata/Metadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* file that was distributed with this source code.
*/

namespace Symfony\AI\Platform\Result\Metadata;
namespace Symfony\AI\Platform\Metadata;

/**
* @implements \IteratorAggregate<string, mixed>
Expand Down
2 changes: 1 addition & 1 deletion ...rc/Result/Metadata/MetadataAwareTrait.php → ...tform/src/Metadata/MetadataAwareTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* file that was distributed with this source code.
*/

namespace Symfony\AI\Platform\Result\Metadata;
namespace Symfony\AI\Platform\Metadata;

/**
* @author Denis Zunke <denis.zunke@gmail.com>
Expand Down
2 changes: 1 addition & 1 deletion src/platform/src/Result/BaseResult.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

namespace Symfony\AI\Platform\Result;

use Symfony\AI\Platform\Result\Metadata\MetadataAwareTrait;
use Symfony\AI\Platform\Metadata\MetadataAwareTrait;

/**
* Base result of converted result classes.
Expand Down
2 changes: 1 addition & 1 deletion src/platform/src/Result/ResultInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

namespace Symfony\AI\Platform\Result;

use Symfony\AI\Platform\Metadata\Metadata;
use Symfony\AI\Platform\Result\Exception\RawResultAlreadySetException;
use Symfony\AI\Platform\Result\Metadata\Metadata;

/**
* @author Christopher Hertel <mail@christopher-hertel.de>
Expand Down
2 changes: 1 addition & 1 deletion src/platform/tests/Bridge/Mistral/TokenOutputProcessorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
use Symfony\AI\Agent\Output;
use Symfony\AI\Platform\Bridge\Mistral\TokenOutputProcessor;
use Symfony\AI\Platform\Message\MessageBagInterface;
use Symfony\AI\Platform\Metadata\Metadata;
use Symfony\AI\Platform\Model;
use Symfony\AI\Platform\Result\Metadata\Metadata;
use Symfony\AI\Platform\Result\Metadata\TokenUsage;
use Symfony\AI\Platform\Result\RawHttpResult;
use Symfony\AI\Platform\Result\ResultInterface;
Expand Down
2 changes: 1 addition & 1 deletion src/platform/tests/Bridge/OpenAi/TokenOutputProcessorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
use Symfony\AI\Agent\Output;
use Symfony\AI\Platform\Bridge\OpenAi\TokenOutputProcessor;
use Symfony\AI\Platform\Message\MessageBagInterface;
use Symfony\AI\Platform\Metadata\Metadata;
use Symfony\AI\Platform\Model;
use Symfony\AI\Platform\Result\Metadata\Metadata;
use Symfony\AI\Platform\Result\Metadata\TokenUsage;
use Symfony\AI\Platform\Result\RawHttpResult;
use Symfony\AI\Platform\Result\ResultInterface;
Expand Down
13 changes: 13 additions & 0 deletions src/platform/tests/Message/MessageBagTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,4 +166,17 @@ public function testContainsImageReturnsTrueWithImage()

$this->assertTrue($messageBag->containsImage());
}

public function testItCanHandleMetadata()
{
$messageBag = new MessageBag();
$metadata = $messageBag->getMetadata();

$this->assertCount(0, $metadata);

$metadata->add('key', 'value');
$metadata = $messageBag->getMetadata();

$this->assertCount(1, $metadata);
}
}
6 changes: 3 additions & 3 deletions ...esult/Metadata/MetadataAwareTraitTest.php → ...tests/Metadata/MetadataAwareTraitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
* file that was distributed with this source code.
*/

namespace Symfony\AI\Platform\Tests\Result\Metadata;
namespace Symfony\AI\Platform\Tests\Metadata;

use PHPUnit\Framework\Attributes\CoversTrait;
use PHPUnit\Framework\Attributes\Small;
use PHPUnit\Framework\Attributes\UsesClass;
use PHPUnit\Framework\TestCase;
use Symfony\AI\Platform\Result\Metadata\Metadata;
use Symfony\AI\Platform\Result\Metadata\MetadataAwareTrait;
use Symfony\AI\Platform\Metadata\Metadata;
use Symfony\AI\Platform\Metadata\MetadataAwareTrait;

#[CoversTrait(MetadataAwareTrait::class)]
#[Small]
Expand Down
4 changes: 2 additions & 2 deletions ...rm/tests/Result/Metadata/MetadataTest.php → src/platform/tests/Metadata/MetadataTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
* file that was distributed with this source code.
*/

namespace Symfony\AI\Platform\Tests\Result\Metadata;
namespace Symfony\AI\Platform\Tests\Metadata;

use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\Small;
use PHPUnit\Framework\TestCase;
use Symfony\AI\Platform\Result\Metadata\Metadata;
use Symfony\AI\Platform\Metadata\Metadata;

#[CoversClass(Metadata::class)]
#[Small]
Expand Down
4 changes: 2 additions & 2 deletions src/platform/tests/Result/BaseResultTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
use PHPUnit\Framework\Attributes\UsesClass;
use PHPUnit\Framework\Attributes\UsesTrait;
use PHPUnit\Framework\TestCase;
use Symfony\AI\Platform\Metadata\Metadata;
use Symfony\AI\Platform\Metadata\MetadataAwareTrait;
use Symfony\AI\Platform\Result\BaseResult;
use Symfony\AI\Platform\Result\Exception\RawResultAlreadySetException;
use Symfony\AI\Platform\Result\Metadata\Metadata;
use Symfony\AI\Platform\Result\Metadata\MetadataAwareTrait;
use Symfony\AI\Platform\Result\RawResultAwareTrait;
use Symfony\AI\Platform\Result\RawResultInterface;

Expand Down
2 changes: 1 addition & 1 deletion src/platform/tests/Result/ResultPromiseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
use PHPUnit\Framework\Attributes\Small;
use PHPUnit\Framework\Attributes\UsesClass;
use PHPUnit\Framework\TestCase;
use Symfony\AI\Platform\Metadata\Metadata;
use Symfony\AI\Platform\Result\BaseResult;
use Symfony\AI\Platform\Result\Exception\RawResultAlreadySetException;
use Symfony\AI\Platform\Result\Metadata\Metadata;
use Symfony\AI\Platform\Result\RawHttpResult;
use Symfony\AI\Platform\Result\RawResultInterface;
use Symfony\AI\Platform\Result\ResultInterface;
Expand Down