[AI Bundle][Platform] Fix Anthropic platform definition

[VincentLanglet]

Q	A
Bug fix?	yes
New feature?	no
Docs?	no
Issues	Fix #363
License	MIT

[VincentLanglet]

@Krystopher88 could you try this and confirm it solves your issue ?

[OskarStark]

Why this change?

[VincentLanglet]

Platform is doing

new ModelClient($httpClient, $apiKey, $version)

Which means that, either

• It has to know the default value, so $version = '2023-06-01', is duplicated
• It requires the logic

null === $version ? new ModelClient($httpClient, $apiKey) : new ModelClient($httpClient, $apiKey, $version);

Also, since I needed to pass the platform version in the AiBundle config, I didn't want to pass

$platform['version'] ?? '2023-06-01',

with the version hard coded a third time.

[xabbuh]

What about moving this parameter at the end instead?

[VincentLanglet]

Might be a solution.

But still I'm unsure it a nice pattern to duplicate the default value '2023-06-01' between the factory and the Model, no ?

[chr-hertel]

Thanks for jumping on that @VincentLanglet!
I'm usually not a huge fan of nullable arguments, and it's true that this is a bit weird in handling and duplicated here.

One thing I noticed when looking at the Anthropics docs again: there are only two version strings at this point 2023-01-01 and the 2023-06-01 we're currently using. and guess what, only one is supported by our implementation here anyways. with 2023-01-01 you get the error "anthropic-version: "2023-01-01" not allowed for this endpoint" error.

So, if you're up for it, let's just clean that up, remove all arguments, the bundle config option and hard code the version in the header: 'anthropic-version' => '2023-06-01' - easier and we don't have to debate the nullable and where not to duplicate stuff 😆

[OskarStark]

Please fix PHPStan, thanks

[OskarStark]

Thanks for fixing this bug Vincent.

[chr-hertel]

@OskarStark saw my comment? any thoughts on that?

[OskarStark]

You mean regarding the defaults? Mixed feelings, as if there is a new version, you can only use it with a new release of the lib, like for the models