[Platform][Mistral] Add ImageUrlNormalizer
#787
Conversation
franzwilding
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Bug
| $contract ?? Contract::create( | ||
| new ToolNormalizer(), | ||
| new DocumentNormalizer(), | ||
| new DocumentUrlNormalizer(), | ||
| ), | ||
| $contract ?? MistralContract::create(), |
There was a problem hiding this comment.
is this described bug the same problem for all other bridges as well?
There was a problem hiding this comment.
@OskarStark I’m not entirely sure, but I believe that’s the case. I haven’t fully figured out how it’s supposed to work yet. What I noticed is that for all bridges without their own contract, the default contract is passed as an argument to the platform factories. Since it’s already set, Contract::create() is never called. One possible solution might be to avoid passing a default contract at all—what do you think?
There was a problem hiding this comment.
you mean via the bundle config, yes lets not inject the default one there, can you open a separate PR please?
There was a problem hiding this comment.
|
@OskarStark I removed the dedicated mistral contract. Once #789 is merged, this PR can also be merged and the new imageUrlNormalizer gets added directly in the platform factory. |
OskarStark
changed the title
ImageUrlNormalizer
|
Thank you @franzwilding. |
3 participants
The mistral platform factory gets a contract per default as an argument, so all the internal normalizers will not be used. This PR changes this by adding a custom MistralContract that will be used (like in the openAI birdge).
This PR also adds an imageUrl normalizer, since the mistral chat api supports image_urls as well.