[Store] Fix CacheStore and InMemoryStore to return similarity scores #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilleislasse
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Bug
OskarStark
reviewed
Nov 11, 2025
|
|
||
| return array_map( | ||
| static fn (array $embedding): VectorDocument => $embedding['document'], | ||
| static fn (array $embedding): VectorDocument => new VectorDocument( |
Contributor
There was a problem hiding this comment.
Can we implement a withScore method to VectorDocument instead?
chr-hertel
approved these changes
Nov 12, 2025
chr-hertel
force-pushed
the
fix-cache-store-vector-scores
branch
from
5259e36 to
65e85c3
Compare
Member
|
Thank you @camilleislasse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
DistanceCalculatorwas calculating distances but not returning them in theVectorDocumentresults. This meant queries toCacheStoreandInMemoryStorereturneddocuments without score information, making it impossible to determine result relevance.
Changes
This fix creates new
VectorDocumentinstances with the calculated distance as thescoreproperty, matching the pattern used by other stores (Redis, MariaDb, Postgres).