Skip to content

[Store][MariaDB] quote vector field name #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

[Store][MariaDB] quote vector field name #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/store/src/Bridge/MariaDb/Store.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ public function setup(array $options = []): void
CREATE TABLE IF NOT EXISTS %1$s (
id BINARY(16) NOT NULL PRIMARY KEY,
metadata JSON,
%2$s VECTOR(%4$d) NOT NULL,
VECTOR INDEX %3$s (%2$s)
`%2$s` VECTOR(%4$d) NOT NULL,
VECTOR INDEX %3$s (`%2$s`)
)
SQL,
$this->tableName,
Expand Down Expand Up @@ -115,9 +115,9 @@ public function add(VectorDocument ...$documents): void
$statement = $this->connection->prepare(
\sprintf(
<<<'SQL'
INSERT INTO %1$s (id, metadata, %2$s)
INSERT INTO %1$s (id, metadata, `%2$s`)
VALUES (:id, :metadata, VEC_FromText(:vector))
ON DUPLICATE KEY UPDATE metadata = :metadata, %2$s = VEC_FromText(:vector)
ON DUPLICATE KEY UPDATE metadata = :metadata, `%2$s` = VEC_FromText(:vector)
SQL,
$this->tableName,
$this->vectorFieldName,
Expand Down Expand Up @@ -148,7 +148,7 @@ public function query(Vector $vector, array $options = []): array
$statement = $this->connection->prepare(
\sprintf(
<<<'SQL'
SELECT id, VEC_ToText(%1$s) embedding, metadata, VEC_DISTANCE_EUCLIDEAN(%1$s, VEC_FromText(:embedding)) AS score
SELECT id, VEC_ToText(`%1$s`) embedding, metadata, VEC_DISTANCE_EUCLIDEAN(`%1$s`, VEC_FromText(:embedding)) AS score
FROM %2$s
%3$s
ORDER BY score ASC
Expand Down
6 changes: 3 additions & 3 deletions src/store/tests/Bridge/MariaDb/StoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function testQueryWithMaxScore()

// Expected SQL query with max score
$expectedQuery = <<<'SQL'
SELECT id, VEC_ToText(embedding) embedding, metadata, VEC_DISTANCE_EUCLIDEAN(embedding, VEC_FromText(:embedding)) AS score
SELECT id, VEC_ToText(`embedding`) embedding, metadata, VEC_DISTANCE_EUCLIDEAN(`embedding`, VEC_FromText(:embedding)) AS score
FROM embeddings_table
WHERE VEC_DISTANCE_EUCLIDEAN(embedding, VEC_FromText(:embedding)) <= :maxScore
ORDER BY score ASC
Expand Down Expand Up @@ -80,7 +80,7 @@ public function testQueryWithoutMaxScore()

// Expected SQL query without maxScore
$expectedQuery = <<<'SQL'
SELECT id, VEC_ToText(embedding) embedding, metadata, VEC_DISTANCE_EUCLIDEAN(embedding, VEC_FromText(:embedding)) AS score
SELECT id, VEC_ToText(`embedding`) embedding, metadata, VEC_DISTANCE_EUCLIDEAN(`embedding`, VEC_FromText(:embedding)) AS score
FROM embeddings_table

ORDER BY score ASC
Expand Down Expand Up @@ -127,7 +127,7 @@ public function testQueryWithCustomLimit()

// Expected SQL query with custom limit
$expectedQuery = <<<'SQL'
SELECT id, VEC_ToText(embedding) embedding, metadata, VEC_DISTANCE_EUCLIDEAN(embedding, VEC_FromText(:embedding)) AS score
SELECT id, VEC_ToText(`embedding`) embedding, metadata, VEC_DISTANCE_EUCLIDEAN(`embedding`, VEC_FromText(:embedding)) AS score
FROM embeddings_table

ORDER BY score ASC
Expand Down