[Store] Add a way to bypass document loading in Indexer #911
Conversation
lyrixx
commented
Nov 20, 2025
lyrixx
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Docs? | |
| Issues | Fix #875 |
| License | MIT |
lyrixx
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Feature
|
Before fixing test & co, is this the way to go? |
| private VectorizerInterface $vectorizer, | ||
| private StoreInterface $store, | ||
| string|array|null $source = null, | ||
| EmbeddableDocumentInterface|array|null $document = [], |
There was a problem hiding this comment.
| EmbeddableDocumentInterface|array|null $document = [], | |
| EmbeddableDocumentInterface|array|null $documents = [], |
?
| } | ||
|
|
||
| public function withSource(string|array $source): self | ||
| public function withSource(EmbeddableDocumentInterface|string|array $source): self |
There was a problem hiding this comment.
Why should we accept the EmbeddableDocumentInterface here too?
| return new self($this->loader, $this->vectorizer, $this->store, $source, [], $this->filters, $this->transformers, $this->logger); | ||
| } | ||
|
|
||
| public function withDocument(EmbeddableDocumentInterface|array $document): self |
There was a problem hiding this comment.
| public function withDocument(EmbeddableDocumentInterface|array $document): self | |
| public function withDocuments(array $documents): self |
?
|
Lets wait for @chr-hertel here |
|
with without a source provided, that implementation will be called with but that's basically just another idea, but i just struggle with state in constructors - Oskar knows about that flaw in my mind already :D I think that solution is alright here, I would just omit the |
4 participants
