[AI Bundle] Fix: Process ai.model configuration and pass to ModelCatalog services #914
+298
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TNAJanssen
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
Collaborator
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
carsonbot
changed the title
TNAJanssen
changed the title
OskarStark
added a commit
that referenced
this pull request
Nov 21, 2025
… (OskarStark) This PR was squashed before being merged into the main branch. Discussion ---------- [AI Bundle] Process model configuration from semantic config | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | Fixes #898 | License | MIT Replaces #914 ## Summary The `ai.model` configuration in the AI Bundle is now properly processed and passed to `ModelCatalog` services. Previously, the configuration was validated but never used by the bundle, requiring users to manually configure services in `services.yaml`. ## Changes - Added `processModelConfig()` method to process model configuration from semantic config - Uses the `class` field from the config (introduced in #920) - Support for all platforms that have a ModelCatalog service - Proper handling of vertexai platform name mapping to vertexai.gemini ## Example With this fix, the following configuration now works as expected: ```yaml ai: model: ollama: custom-model-name: class: Symfony\AI\Platform\Bridge\Ollama\Ollama capabilities: - input-text - output-text ``` The model will be properly passed to the `OllamaModelCatalog` constructor without requiring manual service configuration. Commits ------- 2884d29 [AI Bundle] Process model configuration from semantic config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
ai.modelconfiguration inai.yamlwas validated but never processed or passed toModelCatalogservices. This fix implements the missing functionality to wire model configuration toModelCatalogconstructors.Changes
AiBundle::loadExtension()to process all configured modelsprocessModelConfig()method to:ModelCatalogservice IDs (with special handling forvertexaiandeleven_labs)Capabilityenum instances$additionalModelsarray in the format expected byModelCatalogModelCatalogservice definitiongetModelClassForPlatform()method to map platform names to their corresponding model classesadditionalModelsin theirModelCatalogconstructorsTesting