Skip to content

[Store][MariaDB] Add support for custom WHERE clause #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2025
Merged

[Store][MariaDB] Add support for custom WHERE clause #918

merged 1 commit into from
Nov 21, 2025

Conversation

@lyrixx
Copy link
Member

@lyrixx lyrixx commented Nov 20, 2025

Q A
Bug fix? no
New feature? yes
Docs? no
Issues
License MIT

Usage:

$matchesInB = $this->store->query($vectorA, [
    'maxScore' => 0.66,
    'limit' => 3,
    'where' => 'crawl_id = :crawl_id',
    'params' => ['crawl_id' => $crawlBId],
]);

@carsonbot carsonbot added Feature New feature Store Issues & PRs about the AI Store component Status: Needs Review labels Nov 20, 2025
@lyrixx lyrixx force-pushed the store-mariadb-where branch from 1cc53d0 to e4e4e28 Compare November 20, 2025 16:41
chr-hertel
chr-hertel reviewed Nov 20, 2025
View reviewed changes
@lyrixx lyrixx force-pushed the store-mariadb-where branch from e4e4e28 to 4a1c1d1 Compare November 21, 2025 10:06
@lyrixx lyrixx force-pushed the store-mariadb-where branch from 4a1c1d1 to 82e4110 Compare November 21, 2025 10:08
lyrixx
lyrixx commented Nov 21, 2025
View reviewed changes
src/store/tests/Bridge/Postgres/StoreTest.php
$store = new Store($pdo, 'embeddings_table', 'embedding');

$expectedSql = 'INSERT INTO embeddings_table (id, metadata, embedding)
$expectedQuery = 'INSERT INTO embeddings_table (id, metadata, embedding)
Copy link
Member Author

@lyrixx lyrixx Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the same variable names a in MariaDB/Store

src/store/tests/Bridge/Postgres/StoreTest.php
Comment on lines +40 to +42
$this->assertSame($this->normalizeQuery($expectedQuery), $this->normalizeQuery($sql));

return true;
Copy link
Member Author

@lyrixx lyrixx Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging is much more easier !

@chr-hertel
Copy link
Member

chr-hertel commented Nov 21, 2025

Thank you @lyrixx.

@chr-hertel chr-hertel merged commit b3e2d89 into symfony:main Nov 21, 2025
15 checks passed
@lyrixx lyrixx deleted the store-mariadb-where branch November 21, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chr-hertel chr-hertel chr-hertel approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees

No one assigned

Labels

Feature New feature Status: Reviewed Store Issues & PRs about the AI Store component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lyrixx @chr-hertel @carsonbot