[AI Bundle][VertexAI] factory get called with wrong arguments #963
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzwilding
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
added
Status: Needs Review
AI Bundle
Contributor
|
Can you please add a test to avoid regressions in the future? |
OskarStark
changed the title
Contributor
Author
|
@OskarStark I already implemented the test some time ago, but the problem here is, that the platform is able to be created. Anyway. I added another check to see if the number of arguments of the factory method is gte the number of arguments. It is not very robust or elegant, but it catches at least some of the signature-mismatching problems. |
OskarStark
approved these changes
Nov 24, 2025
Contributor
|
Good catch, thanks Franz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertex ai factory
create´method get called with one wrong "null" parameter. This removes the eventDispatcher, because it would be the 5th argument. Since method signature still is valid with null as 4th parameter, myAiBundleTest::testExtensionLoadDoesNotThrow` test did not catch it.